Skip to content

ci: disable Elementary artifact hooks during seed#2236

Merged
arbiv merged 1 commit into
masterfrom
cursor/fix-dbt-run-results-relation-b5ef
May 26, 2026
Merged

ci: disable Elementary artifact hooks during seed#2236
arbiv merged 1 commit into
masterfrom
cursor/fix-dbt-run-results-relation-b5ef

Conversation

@arbiv
Copy link
Copy Markdown
Contributor

@arbiv arbiv commented May 19, 2026 •
edited by coderabbitai Bot
Loading

Summary

  • Disable Elementary run-result and invocation artifact uploads during the E2E dbt seed step.
  • Keep artifact uploads enabled for the later run/test/monitor steps where Elementary models exist.

Context

The seed step runs before Elementary models are created. With dbt 1.11, missing Elementary relations can propagate as rendered strings into adapter relation APIs during on-run-end, causing warehouse CI failures such as 'str' object has no attribute 'database'.

Testing

  • ELEMENTARY_DBT_PACKAGE_PATH=/tmp/dbt-data-reliability-ci-inspect HOME=/tmp/elementary-repro-home dbt seed -f --target duckdb --project-dir tests/e2e_dbt_project --vars '{"disable_run_results": true, "disable_dbt_invocation_autoupload": true}'
  • ELEMENTARY_DBT_PACKAGE_PATH=/tmp/dbt-data-reliability-ci-inspect HOME=/tmp/elementary-repro-bq-home dbt compile --no-populate-cache --inline "{{ elementary.on_run_end() }}" --target bigquery --project-dir tests/e2e_dbt_project --vars '{"disable_run_results": true, "disable_dbt_invocation_autoupload": true}'
Open in Web Open in Cursor 

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow test execution process to improve testing efficiency and reliability.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 30edd190-4f23-4246-9e67-3fc85c569fa8

📥 Commits

Reviewing files that changed from the base of the PR and between 5d08a08 and 2ec8c42.

📒 Files selected for processing (1)
  • .github/workflows/test-warehouse.yml

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📝 Walkthrough

Walkthrough

The workflow file updates the E2E dbt seed step to invoke dbt seed -f with additional variables that disable run-results output and dbt invocation autoupload. Comments clarify the sequencing rationale: seeding must occur before Elementary models are created to prevent artifact hooks from attempting inserts into missing relations.

Changes

dbt Seed Workflow Configuration

Layer / File(s) Summary
dbt seed step with artifact hook configuration
.github/workflows/test-warehouse.yml		 The "Seed e2e dbt project" workflow step is updated from a single-line dbt seed to a multi-line dbt seed -f invocation that passes --vars to disable run-results output and dbt invocation autoupload, with comments explaining why seeding occurs before Elementary models are created.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

🐰 A seed must come before the bloom,
So hooks won't search an empty room,
With flags and vars, the path is clear—
Elementary models shall appear! 🌱

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-dbt-run-results-relation-b5ef

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

👋 @arbiv
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@arbiv arbiv marked this pull request as ready for review May 26, 2026 16:22
@arbiv arbiv merged commit d8cf87f into master May 26, 2026
24 of 28 checks passed
@arbiv arbiv deleted the cursor/fix-dbt-run-results-relation-b5ef branch May 26, 2026 16:22
devin-ai-integration[bot]
devin-ai-integration Bot reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@elazarlachkar elazarlachkar elazarlachkar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arbiv @elazarlachkar @cursoragent